Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor concept features #10

Closed
3 tasks done
reckart opened this issue Mar 31, 2018 · 2 comments
Closed
3 tasks done

Refactor concept features #10

reckart opened this issue Mar 31, 2018 · 2 comments
Assignees
Milestone

Comments

@reckart
Copy link
Member

reckart commented Mar 31, 2018

The current approach of listing all possible concepts in the feature type list in the feature editor is not scalable and not flexible enough. Instead, we need a generic concept of a KB feature and separately from that one or more ways to control the scope of the feature, i.e. which values it can assume.

  • Instead polluting the feature types dropdown with concepts, show only a generic "Concept" type and choose the specific scope later
  • Allow choosing a specific KB or any KB
  • Allow creation of concept features which can accept "any" concept
@reckart reckart added this to the 0.3.0 milestone Mar 31, 2018
@reckart reckart self-assigned this Mar 31, 2018
reckart added a commit that referenced this issue Apr 2, 2018
- Added a very simple traits editor for concept features
reckart added a commit that referenced this issue Apr 2, 2018
- Properly upgrade existing concept features to the new traits-based configuration
- Added JavaDoc
- Fixed various bugs
- Marked "scope" as required field
- Added readInstance and readConcept methods to KnowledgeBaseService which look for a concept/instance in all KBs of a project
- Added method to get knowledge base by its ID to KnowledgeBaseService
reckart added a commit that referenced this issue Apr 2, 2018
- Fix problem that ConceptFeatureSupport is claiming responsibility for all feature types
reckart added a commit that referenced this issue Apr 2, 2018
- Fix serialization problem.
reckart added a commit that referenced this issue Apr 3, 2018
- Support "ANY" as a scope (although it is a really really bad implementation and we really need a better concept selection UI!)
reckart added a commit that referenced this issue Apr 3, 2018
- Support "ANY" as a scope (although it is a really really bad implementation and we really need a better concept selection UI!)
@rcffc
Copy link
Contributor

rcffc commented Apr 4, 2018

@reckart What is meant with trait and scope in the context of ConceptFeatureTraits?

@reckart
Copy link
Member Author

reckart commented Apr 4, 2018

"traits" are the configuration settings specific to a particular annotation type. I.e. all settings which are not directly part of the AnnotationType entity.

The "scope" and the "repositoryId" of the concept feature are such traits. The "repositoryId" identifies a particular KB to use (can be null to use any). The "scope" determines the concept whose instances we want to link with the feature.

I imagine more traits to come, e.g. one that configures whether we only want to link instances of the concept identified by the "scope" or if we also want to be able to link child concepts (and possibly again their instances).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants