-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor concept features #10
Comments
- Added a very simple traits editor for concept features
- Properly upgrade existing concept features to the new traits-based configuration - Added JavaDoc - Fixed various bugs - Marked "scope" as required field - Added readInstance and readConcept methods to KnowledgeBaseService which look for a concept/instance in all KBs of a project - Added method to get knowledge base by its ID to KnowledgeBaseService
- Fix problem that ConceptFeatureSupport is claiming responsibility for all feature types
- Support "ANY" as a scope (although it is a really really bad implementation and we really need a better concept selection UI!)
- Support "ANY" as a scope (although it is a really really bad implementation and we really need a better concept selection UI!)
@reckart What is meant with trait and scope in the context of ConceptFeatureTraits? |
"traits" are the configuration settings specific to a particular annotation type. I.e. all settings which are not directly part of the The "scope" and the "repositoryId" of the concept feature are such traits. The "repositoryId" identifies a particular KB to use (can be null to use any). The "scope" determines the concept whose instances we want to link with the feature. I imagine more traits to come, e.g. one that configures whether we only want to link instances of the concept identified by the "scope" or if we also want to be able to link child concepts (and possibly again their instances). |
The current approach of listing all possible concepts in the feature type list in the feature editor is not scalable and not flexible enough. Instead, we need a generic concept of a KB feature and separately from that one or more ways to control the scope of the feature, i.e. which values it can assume.
The text was updated successfully, but these errors were encountered: