Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensible merge strategies for curation #2642

Closed
reckart opened this issue Oct 4, 2021 · 0 comments · Fixed by #2645
Closed

Extensible merge strategies for curation #2642

reckart opened this issue Oct 4, 2021 · 0 comments · Fixed by #2645
Assignees
Labels
Projects
Milestone

Comments

@reckart
Copy link
Member

reckart commented Oct 4, 2021

Is your feature request related to a problem? Please describe.
Currently, it is not easy/possible to add new merging strategies for curation.

Describe the solution you'd like
It would be nice if there would be an extension mechanism to allow adding and configuring merge strategies for curation.

@reckart reckart added this to the 22.0 milestone Oct 4, 2021
@reckart reckart self-assigned this Oct 4, 2021
@reckart reckart added this to 🔖 To do in Kanban via automation Oct 4, 2021
@reckart reckart changed the title Configurable merging strategies for curation Configurable merge strategies for curation Oct 4, 2021
@reckart reckart changed the title Configurable merge strategies for curation Extensible merge strategies for curation Oct 4, 2021
reckart added a commit that referenced this issue Oct 5, 2021
- Added new project settings panel to configure the merge strategy
- Added threshold-based merge strategy
- Moved curation-sidbear code into a new package
- WIP
reckart added a commit that referenced this issue Oct 5, 2021
reckart added a commit that referenced this issue Oct 5, 2021
- Fix up configuration of default merge strategy in the project settings
reckart added a commit that referenced this issue Oct 5, 2021
- Move anonymous curation setting from the main project details to the curation settings page
reckart added a commit that referenced this issue Oct 5, 2021
- Move CAS merging code out of legacy module
reckart added a commit that referenced this issue Oct 5, 2021
- Remove unnecessary empty lines
reckart added a commit that referenced this issue Oct 6, 2021
- Move code around to avoid circular dependencies
- Right sidebar of the dashboard now managed via an extension point
reckart added a commit that referenced this issue Oct 6, 2021
reckart added a commit that referenced this issue Oct 7, 2021
- Facilitate obtaining a merge strategy from the CurationService
- Remove checkbox for incomplete merging from the merge dialog
reckart added a commit that referenced this issue Oct 8, 2021
- Added merge strategy settings to the merge dialog
- Added option to update the project-level settings from the merge dialog
reckart added a commit that referenced this issue Oct 9, 2021
- Factor re-usable merging code out into a service bean
reckart added a commit that referenced this issue Oct 9, 2021
- Factor retrieval of all CASes required for a curation out into the document service and use shared CASes for the purpose (was done by the curation page before, but not by the curation sidebar)
reckart added a commit that referenced this issue Oct 10, 2021
reckart added a commit that referenced this issue Oct 10, 2021
- Moved CurationDocumentService out of the legacy module
reckart added a commit that referenced this issue Oct 11, 2021
reckart added a commit that referenced this issue Oct 11, 2021
- Fix Spring factory registration
- Set min/max values for thresholds in editor
reckart added a commit that referenced this issue Oct 11, 2021
- Move curated documents project exporter to curation module
reckart added a commit that referenced this issue Oct 11, 2021
- Centralize export fallback format
reckart added a commit that referenced this issue Oct 11, 2021
- Set set and add percent marker
reckart added a commit that referenced this issue Oct 11, 2021
reckart added a commit that referenced this issue Oct 11, 2021
…into feature/2096-Generify-exporter

* feature/2642-Extensible-merge-strategies-for-curation: (23 commits)
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  No issue. Fix typo.
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-21.0-rc-4
  #2642 - Extensible merge strategies for curation
  ...

% Conflicts:
%	inception/inception-project-export/src/main/java/de/tudarmstadt/ukp/inception/project/export/task/curated/CuratedDocumentsProjectExportTask.java
%	inception/inception-ui-dashboard/pom.xml
reckart added a commit that referenced this issue Oct 11, 2021
reckart added a commit that referenced this issue Oct 11, 2021
reckart added a commit that referenced this issue Oct 11, 2021
reckart added a commit that referenced this issue Oct 11, 2021
- Added exporter for the curation workflow settings
reckart added a commit that referenced this issue Oct 11, 2021
reckart added a commit that referenced this issue Oct 11, 2021
reckart added a commit that referenced this issue Oct 12, 2021
reckart added a commit that referenced this issue Oct 12, 2021
@reckart reckart linked a pull request Oct 12, 2021 that will close this issue
2 tasks
Kanban automation moved this from 🔖 To do to 🍹 Done Oct 12, 2021
reckart added a commit that referenced this issue Oct 12, 2021
…le-merge-strategies-for-curation

#2642 - Extensible merge strategies for curation
reckart added a commit that referenced this issue Oct 12, 2021
* main:
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-21.0.1
  #2647 - IndexOutOfBoundsException if project name consists only of characters now valid for a slug
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-21.0
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation
  #2642 - Extensible merge strategies for curation

% Conflicts:
%	inception/inception-curation/pom.xml
reckart added a commit that referenced this issue Oct 12, 2021
reckart added a commit that referenced this issue Oct 13, 2021
* main:
  No issue. Switch SourceDocumentExporter to auto-config
  #2642 - Extensible merge strategies for curation
reckart added a commit that referenced this issue Oct 13, 2021
- Must set project on import (also in test)
reckart added a commit that referenced this issue Oct 16, 2021
* main:
  No issue. Make form more concise.
  No issue. Bug form and additional links.
  No issue. Bug form.
  No issue. Bug form.
  No issue. Bug form.
  No issue. Bug form.
  #2630 - Upgrade dependencies (22.0)
  #2642 - Extensible merge strategies for curation
  #2630 - Upgrade dependencies (22.0)
  No issue. Switch SourceDocumentExporter to auto-config
  #2642 - Extensible merge strategies for curation
  #2630 - Upgrade dependencies (22.0)
  #2630 - Upgrade dependencies (22.0)
  #2630 - Upgrade dependencies (22.0)
  #2630 - Upgrade dependencies (22.0)
  #2630 - Upgrade dependencies (22.0)
@reckart reckart reopened this Oct 18, 2021
Kanban automation moved this from 🍹 Done to 🏃‍♀️ In progress Oct 18, 2021
reckart added a commit that referenced this issue Oct 18, 2021
- Allow returning messages collected during merging
- Allow better access to the initial CAS e.g. for the purpose of loading it as part of a merge operation
reckart added a commit that referenced this issue Oct 19, 2021
- Disable token and sentence layer diffing based on whether editing them is enabled or not - at least for the purpose of merging and not for unit tests which rely on it
- Fixes unit test
reckart added a commit that referenced this issue Oct 19, 2021
- Move AnnotationEditorPropertiesImpl to auto-configuration
- Fixes tests
@reckart reckart closed this as completed Oct 19, 2021
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Oct 19, 2021
reckart added a commit that referenced this issue Oct 19, 2021
* main: (74 commits)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-21.1
  #2642 - Extensible merge strategies for curation
  #2667 - Add format IDs to format documentation
  #2666 - CoNLL 2000 and CoNLL 2002 format IDs are mixed up
  #2642 - Extensible merge strategies for curation
  #2653 - ReferenceError: fragment is not defined
  #2655 - Curated CASes are exported to the wrong spot
  #2654 - Programmatically created AnnotationLayers are not curatable
  #1778 - Make tokenization editable
  #2642 - Extensible merge strategies for curation
  #1778 - Make tokenization editable
  No issue. Mini-optimizatioin: load workload settings only once.
  No issue. Add JavaDoc.
  No issue. Fix potential race condition when creating workload management settings by synchronizing the loadOrCreateWorkloadManagerConfiguration method.
  #1778 - Make tokenization editable
  #1778 - Make tokenization editable
  No issue. Bunch of small fixes
  #2656 - Constructor injection for most project exporters
  No issue. Make form more concise.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Kanban
  
🍹 Done
Development

Successfully merging a pull request may close this issue.

1 participant