Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull actions code out of BratAnnotationEditor #2716

Closed
reckart opened this issue Nov 27, 2021 · 0 comments
Closed

Pull actions code out of BratAnnotationEditor #2716

reckart opened this issue Nov 27, 2021 · 0 comments
Assignees
@reckart
Labels
Module: Annotation ⚙️ Refactoring
Projects
Kanban
Milestone
22.0

Comments

@reckart
Copy link
Member

reckart commented Nov 27, 2021

Describe the refactoring action
Pull the code that handles the different user actions in the annotation interface out of the BratAnnotationEditor and into classes that extend the DIAM EditorAjaxRequestHandlerBase class.

Expected benefit
First step to harmonize the action handling code and make it re-usable between different editors.
@reckart reckart added this to the 22.0 milestone Nov 27, 2021
@reckart reckart self-assigned this Nov 27, 2021
@reckart reckart added this to 🔖 To do in Kanban via automation Nov 27, 2021
reckart added a commit that referenced this issue Nov 27, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
966709c 
- Pulled out code for handling
reckart added a commit that referenced this issue Nov 27, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
53fc930 
- Pulled out code for handling custom JS actions and extension actions
reckart added a commit that referenced this issue Nov 27, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
683931b 
- Pulled out code for creating span annotations
reckart added a commit that referenced this issue Nov 27, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
62420b9 
- Pulled out code for creating relation annotations
reckart added a commit that referenced this issue Nov 27, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
4d19e10 
- Pulled out code for handling lazy detail lookups
reckart added a commit that referenced this issue Nov 27, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
eec193e 
- Move custom Jackson serializers to support module
reckart added a commit that referenced this issue Nov 27, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
b06f3bb 
- Clean up and remove unused code
reckart added a commit that referenced this issue Nov 27, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
ad4cc02 
- Start pulling out annotation commands being sent to the server to a separate class
reckart added a commit that referenced this issue Nov 27, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
bbe86bd 
- Cleaning up a bit
reckart added a commit that referenced this issue Nov 27, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
6d1116e 
- Fix y-positioning of horizontal spacers
reckart added a commit that referenced this issue Nov 27, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
04e89b9 
- Fix relation creation bug
- Switch to DiamAjax for certain annotation actions
reckart added a commit that referenced this issue Nov 27, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
52d6542 
- Switch to SelectAnnotationHandler for selecting any span/arc annotation
- Fix update of detail panel when selecting an annotation
- Remove unused code
reckart added a commit that referenced this issue Nov 27, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
5e20796 
- Fix dependencies
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
a690188 
- Fix up beans into auto-config to make the test work again
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
bfd0563 
- Fix selection in DiamDebugEditor
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
f394994 
- Fix editor not jumping up when selecting an annotation / re-rendering
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
1a0cd87 
- Fixing dependencies
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
5fe8a3a 
- Improving render performance
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
c44603f 
- Improving render performance
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
65470d9 
- Improving render performance
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
a8d19aa 
- Improving render performance
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
f165b20 
- Improving render performance
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
9534b37 
- Fix dependency
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
Merge pull request #2717 from inception-project/refactoring/2716-Pull…
acf0116 
…-actions-code-out-of-BratAnnotationEditor

#2716 - Pull actions code out of BratAnnotationEditor
@reckart reckart closed this as completed Nov 28, 2021
Kanban automation moved this from 🔖 To do to 🍹 Done Nov 28, 2021
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
30693ae 
- Fix slot filling
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
5dbf9a1 
- Clean up API
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
d91621d 
- Switch from hard-coded calling of handlers to using the handler registry in brat editor
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
582d8c7 
- Moved DiamAjax to diam module
reckart added a commit that referenced this issue Nov 28, 2021
@reckart
#2716 - Pull actions code out of BratAnnotationEditor
ae15aec 
- Fixed javadoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
Module: Annotation ⚙️ Refactoring
Projects
Kanban
  
🍹 Done
Milestone
22.0
Development

No branches or pull requests
1 participant
@reckart