Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude empty annotations from String Matcher and OpenNLP recommenders #2855

Closed
reckart opened this issue Feb 13, 2022 · 0 comments
Closed

Exclude empty annotations from String Matcher and OpenNLP recommenders #2855

reckart opened this issue Feb 13, 2022 · 0 comments
Assignees
@reckart
Labels
Module: Recommender
Projects
Kanban
Milestone
22.4

Comments

@reckart
Copy link
Member

reckart commented Feb 13, 2022

Describe the bug
Training on blank/empty annotations isn't really helpful. Training on zero-width annotations even triggers an exception in the String Matching recommender. So why include them in the data at all...

To Reproduce
Steps to reproduce the behavior:

  1. Configure a string-matching recommender
  2. Make a zero-width annotation

Expected behavior
Probably best to ignore zero-width and blank annotations during training.

Please complete the following information:

  • Version and build ID: 22.3
@reckart reckart added this to the 22.4 milestone Feb 13, 2022
@reckart reckart self-assigned this Feb 13, 2022
@reckart reckart added this to 🔖 To do in Kanban via automation Feb 13, 2022
reckart added a commit that referenced this issue Feb 13, 2022
@reckart
#2855 - Exclude empty annotations from String Matcher and OpenNLP rec…
cbdff8e 
…ommenders

- Ignore zero-width annotations and annotations on whitespace only during training/evaluation
reckart added a commit that referenced this issue Feb 14, 2022
@reckart
Merge pull request #2856 from inception-project/bugfix/2855-Exclude-e…
7ddbc36 
…mpty-annotations-from-String-Matcher-and-OpenNLP-recommenders

#2855 - Exclude empty annotations from String Matcher and OpenNLP recommenders
@reckart reckart closed this as completed Feb 14, 2022
Kanban automation moved this from 🔖 To do to 🍹 Done Feb 14, 2022
reckart added a commit that referenced this issue Feb 14, 2022
@reckart
Merge branch 'release/22.x'
c933dbd 
* release/22.x:
  #2855 - Exclude empty annotations from String Matcher and OpenNLP recommenders
reckart added a commit that referenced this issue Feb 14, 2022
@reckart
Merge branch 'main' into refactoring/2853-Properly-take-control-over-…
bc0aa62 
…AnnotatorJS-editor-code

* main:
  #2855 - Exclude empty annotations from String Matcher and OpenNLP recommenders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
Module: Recommender
Projects
Kanban
  
🍹 Done
Milestone
22.4
Development

No branches or pull requests
1 participant
@reckart