Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Every Document becomes abandoned #3229

Closed
akbugert opened this issue Jul 25, 2022 · 1 comment
Closed

Every Document becomes abandoned #3229

akbugert opened this issue Jul 25, 2022 · 1 comment
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Dynamic Workload
Projects
Kanban
Milestone
23.10

Comments

@akbugert
Copy link

Describe the bug

After the Abandonation timeout has run out, all documents are shown as abandoned despite some being finished by annotators previously.
For long running annotation, it is not possible to distinguish between actually abandoned documents and finished documents which are shown as being abandoned.

To Reproduce

  1. Create new project
  2. Add a document
  3. Change Workload to dynamic
  4. In the Workload View:
    1. enable "Handle abandoned documents"
    2. Set "Abandonation timeout" to 1 Minute
    3. Leave the remaining setting to the default
  5. Annotate the document
  6. Mark the document as finished
  7. Switch back to the workload view
    1. Note that the document status is finished (checkmark symbol)
    2. Wait one minute, then refresh
    3. Now, the document is abandoned (symbol background color is yellow) despite it being finished by the annotator previously.

Expected behavior

Finished documents stay finished without being abandoned.

Screenshots

No response

Environment

Version and build ID: INCEpTION -- 23.9 (2022-07-23 09:01:57, build 0f9d854)
Operating system: Linux Mint 20.3
Browser: Firefox 102.0

Additional context

No response
@akbugert akbugert added Triage 🐛Bug Something isn't working labels Jul 25, 2022
@reckart
Copy link
Member

reckart commented Jul 25, 2022

Finished documents should never be automatically marked as abandoned.

@reckart reckart added this to the 24.0 milestone Jul 25, 2022
@reckart reckart modified the milestones: 24.0, 23.10 Jul 25, 2022
@akbugert akbugert mentioned this issue Jul 25, 2022
Closed
@reckart reckart changed the title Dynamic Workload: Every Document becomes abandoned Every Document becomes abandoned Jul 25, 2022
@reckart reckart self-assigned this Jul 25, 2022
@reckart reckart added this to 🔖 To do in Kanban via automation Jul 25, 2022
reckart added a commit that referenced this issue Jul 25, 2022
@reckart
#3229 - Every Document becomes abandoned
5573d5c 
- Only documents in which the annotator state is "in progress" should be marked as abandoned
- When an annotator marks a document as finished, it should be recorded as an explicit annotator action
reckart added a commit that referenced this issue Jul 25, 2022
@reckart
Merge pull request #3232 from inception-project/bugfix/3229-Every-Doc…
5a94498 
…ument-becomes-abandoned

#3229 - Every document becomes abandoned
@reckart reckart closed this as completed Jul 25, 2022
Kanban automation moved this from 🔖 To do to 🍹 Done Jul 25, 2022
reckart added a commit that referenced this issue Jul 26, 2022
@reckart
Merge branch 'release/23.x'
5245a58 
* release/23.x:
  #3229 - Every Document becomes abandoned
  #3228 - Flipped Behavior in Change document status

% Conflicts:
%	inception/inception-workload-dynamic/src/main/java/de/tudarmstadt/ukp/inception/workload/dynamic/annotation/DynamicAnnotatorWorkflowActionBarItemGroup.java
%	inception/inception-workload-dynamic/src/main/java/de/tudarmstadt/ukp/inception/workload/dynamic/management/DynamicWorkloadManagementPage.java
%	inception/inception-workload-dynamic/src/main/java/de/tudarmstadt/ukp/inception/workload/dynamic/management/support/AnnotationStateList.java
%	inception/inception-workload-dynamic/src/main/resources/META-INF/asciidoc/user-guide/workload_dynamic.adoc
reckart added a commit that referenced this issue Jul 26, 2022
@reckart
Merge branch 'main' into refactoring/3225-Consolidate-access-permissi…
721c30e 
…on-code

* main:
  #3229 - Every Document becomes abandoned
  #3228 - Flipped Behavior in Change document status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Dynamic Workload
Projects
Kanban
  
🍹 Done
Milestone
23.10
Development

No branches or pull requests
2 participants
@reckart @akbugert