Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotations not created if mouse is released on empty space #3890

Closed
maks1812 opened this issue Mar 21, 2023 · 2 comments
Closed

Annotations not created if mouse is released on empty space #3890

maks1812 opened this issue Mar 21, 2023 · 2 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Annotation
Projects
Kanban
Milestone
27.2

Comments

@maks1812
Copy link

Describe the bug
The process of creating a new span became too sensitive to where your mouse lies. Span will be created only if you release the mouse on exactly the last character. That wasn’t the case before the 27.1 version

To Reproduce
Steps to reproduce the behavior:

highlight multi-words span (mainly words ending with "I") and release the mouse. Span will not be created

Expected behavior
Span should be created.

Screenshots
Screenshot_no_span_if_release

Please complete the following information:

  • Version and build ID: 27.1 build 93bb6f0
  • OS: Linux
  • Browser: FireFox , Google as well

Additional context
@reckart
Copy link
Member

reckart commented Mar 21, 2023

I cannot reproduce it with v27.1 for text that is in the middle of a sentence.

example-multi-word-annotation.mp4

However, I can your problem when the text is at the end of a line and I release the mouse to far to the right in an area where there is no text anymore.

Do you remember what the last version was that you used before v27.1?

@blochsbek
Copy link

26.6

@reckart reckart added 🐛Bug Something isn't working Module: Annotation labels Mar 21, 2023
@reckart reckart self-assigned this Mar 21, 2023
@reckart reckart added this to the 27.2 milestone Mar 21, 2023
@reckart reckart added this to 🔖 To do in Kanban via automation Mar 21, 2023
@reckart reckart changed the title Issue with highlighting multi-word spans Annotations not created if mouse is released on empty space Mar 21, 2023
reckart added a commit that referenced this issue Mar 21, 2023
@reckart
#3890 - Annotations not created if mouse is released on empty space
f14ff78 
- Consider spacing elements when looking for chunks
reckart added a commit that referenced this issue Mar 21, 2023
@reckart
Merge pull request #3891 from inception-project/bugfix/3890-Annotatio…
2f95f64 
…ns-not-created-if-mouse-is-released-on-empty-space

#3890 - Annotations not created if mouse is released on empty space
@reckart reckart closed this as completed Mar 21, 2023
Kanban automation moved this from 🔖 To do to 🍹 Done Mar 21, 2023
reckart added a commit that referenced this issue Mar 21, 2023
@reckart
Merge branch 'release/27.x'
98c6779 
* release/27.x:
  #3890 - Annotations not created if mouse is released on empty space
  #3884 - Telemetry enable setting toggle logic inverted
  No issue. JavaDoc.
reckart added a commit that referenced this issue Mar 27, 2023
@reckart
Merge branch 'main' into feature/3887-Allow-selecting-a-concept-by-br…
9d79ebf 
…owsing-the-KB

* main:
  #3868 - Allow a recommender to force-create annotations
  #3895 - Cannot set value in lookup feature editor when there are constraints
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-27.2
  #3890 - Annotations not created if mouse is released on empty space
  #3884 - Telemetry enable setting toggle logic inverted
  No issue. JavaDoc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Annotation
Projects
Kanban
  
🍹 Done
Milestone
27.2
Development

No branches or pull requests
3 participants
@reckart @maks1812 @blochsbek