Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge label into eligible existing annotation even when stacking is enabled #3940

Closed
parvva opened this issue Apr 14, 2023 · 0 comments
Closed

Merge label into eligible existing annotation even when stacking is enabled #3940

parvva opened this issue Apr 14, 2023 · 0 comments
Assignees
@reckart
Labels
⭐️ Enhancement New feature or request Module: Recommender
Projects
Kanban
Milestone
27.5

Comments

@parvva
Copy link

parvva commented Apr 14, 2023

Is your feature request related to a problem? Please describe.
When stacking and recommender are both enabled on a feature of a layer, merge the label of the first accepted suggestion into the empty trigger annotation and then allow accepting additional suggestions which would be turned into new annotations

Describe the solution you'd like
When stacking is enable on a feature which already has a recommender do:

  1. if there is an existing annotation with no label, merge the suggested label into the annotation
  2. if there is an existing annotation with a label and stacking is allowed, create a new annotation
  3. otherwise update the existing annotation
@reckart reckart changed the title allow creating a span (with stacking) using multiple recommendations Allow creating a span (with stacking) using multiple recommendations Apr 16, 2023
@reckart reckart changed the title Allow creating a span (with stacking) using multiple recommendations Merge label into eligible existing annotation even when stacking is enabled Apr 16, 2023
@reckart reckart added this to the 27.5 milestone Apr 16, 2023
@reckart reckart added this to 🔖 To do in Kanban via automation Apr 16, 2023
@reckart reckart self-assigned this Apr 16, 2023
reckart added a commit that referenced this issue Apr 16, 2023
@reckart
#3940 - Merge label into eligible existing annotation even when stack…
6f15458 
…ing is enabled

- Merge span label into existing span if that span has no value for the given label yet
- Added unit tests
reckart added a commit that referenced this issue Apr 16, 2023
@reckart
Merge pull request #3950 from inception-project/feature/3940-Merge-la…
7499020 
…bel-into-eligible-existing-annotation-even-when-stacking-is-enabled

#3940 - Merge label into eligible existing annotation even when stacking is enabled
@reckart reckart closed this as completed Apr 16, 2023
Kanban automation moved this from 🔖 To do to 🍹 Done Apr 16, 2023
reckart added a commit that referenced this issue Apr 16, 2023
@reckart
Merge branch 'release/27.x'
1dfa9cb 
* release/27.x:
  No issue: Demote some logged message to debug level
  #3940 - Merge label into eligible existing annotation even when stacking is enabled

% Conflicts:
%	inception/inception-active-learning/src/main/java/de/tudarmstadt/ukp/inception/active/learning/ActiveLearningServiceImpl.java
%	inception/inception-recommendation-api/src/main/java/de/tudarmstadt/ukp/inception/recommendation/api/RecommendationService.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/RecommendationEditorExtension.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/RecommendationServiceImpl.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/sidebar/RecommenderInfoPanel.java
%	inception/inception-recommendation/src/test/java/de/tudarmstadt/ukp/inception/recommendation/service/RecommendationServiceImplIntegrationTest.java
reckart added a commit that referenced this issue Apr 18, 2023
@reckart
Merge branch 'main' into feature/3944-Ability-to-use-recommenders-as-…
8370acb 
…curator

* main:
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-27.6
  #3958 - Dynamically sized multi-line string fields no resize automatically
  #3957 - Cannot create project using project-creator role
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-27.5
  #3932 - Upgrade dependencies
  #3953 - Switch core footer items to auto-configuration
  #3951 - Lots of errors and warnings from logging system during startup
  No issue: Demote some logged message to debug level
  #3940 - Merge label into eligible existing annotation even when stacking is enabled

% Conflicts:
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/RecommendationServiceImpl.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/PredictionTask.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Recommender
Projects
Kanban
  
🍹 Done
Milestone
27.5
Development

No branches or pull requests
2 participants
@reckart @parvva