Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF highlighting disables after double-clicking on a recommended annotation #4008

Closed
amckenny opened this issue May 18, 2023 · 2 comments
Closed
Assignees
Projects
Milestone

Comments

@amckenny
Copy link

Describe the bug

When using a recommender in PDF annotation, I get the gray highlights and bubbles. Double-clicking on the gray bubble does remove the recomendation as expected; however, after double-clicking on one of the gray bubbles to remove that recommendation, I am not able to click-drag to annotate anything anymore.

To restore this ability, I need to hover my mouse over one of the other gray boxes (clicking is not necessary). At that point, the ability to click-and-drag for annotation is restored until the next time that I double-click a recommendation to remove it.

To Reproduce

Steps to reproduce the behavior:

  1. Go to a PDF with recommender 'on'
  2. Double-click on the gray bubble above one of the recommendations
  3. Observe that the recommendation goes away
  4. Attempt to click-and-drag over unannotated text
  5. Observe nothing is highlighted
  6. Hover over a recommendation bubble
  7. Attempt to click-and-drag over unannotated text
  8. Observe that selection is highlighted

Expected behavior

Steps to reproduce the behavior:

  1. Go to a PDF with recommender 'on'
  2. Double-click on the gray bubble above one of the recommendations
  3. Observe that the recommendation goes away
  4. Attempt to click-and-drag over unannotated text
  5. Observe that selection is highlighted

Screenshots

screencapture video of bug

Environment

INCEpTION version: 27.0 (2023-03-07 13:00:34, build c9bb50a)

Docker info:
- App Version: inceptionproject/inception:27.0
- DB Version: mariadb:10.7
- (Created using your suggested code from the docker compose code from your website, but changed the app version to 'latest')

Browser info:
- Google Chrome Version 113.0.5672.127 (Official Build) (64-bit)

Additional context

No response

@amckenny amckenny added Triage 🐛Bug Something isn't working labels May 18, 2023
@reckart
Copy link
Member

reckart commented May 23, 2023

Thanks for the issue report and the explanatory video! Looks like the internal state of the PDF editor gets a bit messed up on a reject. I'll have a look.

The message about Relations cannot be created from/to synthetic annotations comes up because you all so slightly move the mouse between pressing and releasing the mouse button - and then the editor recognizes it as a drag action - and drag actions to create relations are not possible on suggestions (as the message says). It would probably be a good idea to look into that as well and make it a bit less sensitive.

@reckart reckart added this to the 28.0 milestone May 23, 2023
@reckart reckart added this to 🔖 To do in Kanban via automation May 23, 2023
@reckart reckart self-assigned this May 23, 2023
reckart added a commit that referenced this issue May 23, 2023
…ded annotation

- Restore ability to select text after doing a double-click
@reckart reckart modified the milestones: 28.0, 27.9 May 23, 2023
@amckenny
Copy link
Author

Great - thanks for your help Richard!

reckart added a commit that referenced this issue May 23, 2023
…ighting-disables-after-double-clicking-on-a-recommended-annotation

#4008 - PDF highlighting disables after double-clicking on a recommended annotation
@reckart reckart closed this as completed May 23, 2023
Kanban automation moved this from 🔖 To do to 🍹 Done May 23, 2023
reckart added a commit that referenced this issue May 23, 2023
* release/27.x:
  #4008 - PDF highlighting disables after double-clicking on a recommended annotation
@reckart reckart modified the milestones: 27.9, 28.0 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Kanban
  
🍹 Done
Development

No branches or pull requests

2 participants