Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid event instantiation when event is not going to be sent #4009

Closed
reckart opened this issue May 23, 2023 · 0 comments
Closed

Avoid event instantiation when event is not going to be sent #4009

reckart opened this issue May 23, 2023 · 0 comments
Assignees
@reckart
Labels
⚙️ Refactoring
Projects
Kanban
Milestone
28.0

Comments

@reckart
Copy link
Member

reckart commented May 23, 2023

Describe the refactoring action
Avoid event instantiation when event is not going to be sent.

Expected benefit
Potentially a little less object creation. Less issues in tests that work with mocking.
@reckart reckart added this to the 28.0 milestone May 23, 2023
@reckart reckart self-assigned this May 23, 2023
@reckart reckart added this to 🔖 To do in Kanban via automation May 23, 2023
reckart added a commit that referenced this issue May 23, 2023
@reckart
#4009 - Avoid event instantiation when event is not going to be sent
2b40c12 
- Introduce new method that takes an event supplier
- Deprecate old method
- Switch to using new method
reckart added a commit that referenced this issue May 23, 2023
@reckart
Merge pull request #4010 from inception-project/refactoring/4009-Avoi…
c58332c 
…d-event-instantiation-when-event-is-not-going-to-be-sent

#4009 - Avoid event instantiation when event is not going to be sent
@reckart reckart closed this as completed May 23, 2023
Kanban automation moved this from 🔖 To do to 🍹 Done May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⚙️ Refactoring
Projects
Kanban
  
🍹 Done
Milestone
28.0
Development

No branches or pull requests
1 participant
@reckart