Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2407 - NPE in curation after adding a feature #2409

Merged
merged 3 commits into from Jun 23, 2021

Conversation

reckart
Copy link
Member

@reckart reckart commented Jun 22, 2021

What's in the PR

  • Remove assumption that FSes being compared must have the same number of features
  • Ensure that curation CAS is upgraded when re-merging/initializing

How to test manually

  • Upload document
  • Create new custom layer with one feature
  • Create annotation of that layer
  • Mark document as finished
  • Start curating the document
  • Re-open the document for annotation
  • Add second feature
  • Open document for annotation
  • Mark document as finished
  • Go back to curation
  • Re-merge document

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Remove assumption that FSes being compared must have the same number of features
- Ensure that curation CAS is upgraded when re-merging/initializing
@reckart reckart added 🐛Bug Something isn't working Module: Curation labels Jun 22, 2021
@reckart reckart added this to the 0.20.0 milestone Jun 22, 2021
@reckart reckart self-assigned this Jun 22, 2021
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Jun 22, 2021
- Used wrong method to obtain feature name
- Remove dependency check exclusions since dependencies moved to more suitable module
@reckart
Copy link
Member Author

reckart commented Jun 23, 2021

Jenkins, can you test this please?

@reckart reckart merged commit 067928b into 0.20.x Jun 23, 2021
@reckart reckart deleted the bugfix/2407-NPE-in-curation-after-adding-a-feature branch June 23, 2021 20:14
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Curation
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant