Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2813 - Recommender calling out to an ELG service #2814

Merged
merged 17 commits into from
Jan 17, 2022

Conversation

reckart
Copy link
Member

@reckart reckart commented Jan 10, 2022

What's in the PR

  • Added a very simple recommendr that can call out to an ELG service - no async support, not even error handling, but already can be used with some (fast) services

How to test manually

  • Create an ELG recommender on a string feature of a span layer
  • Sign in to ELG and fetch the success token the (the ELG session panel in the recommender settings guides you through it)
  • Select a working ELG service, e.g. the GATE English Named Entity Recommender
  • See if the recommender works on the annotation page

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Added a very simple recommendr that can call out to an ELG service - no async support, not even error handling, but already can be used with some (fast) services
@reckart reckart added this to the 23.0 milestone Jan 10, 2022
@reckart reckart self-assigned this Jan 10, 2022
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Jan 10, 2022
- Added a rudimentary search field for locating ELG services from the catalog and filling their data into the respective traits fields
…LG-service

* main:
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-22.1
  No issue - Reduce logging level for the preferences service because it is still spamming a lot to info level
  No issue: Move failOnConcurrentModification method into the FileSystemCasStorageDriver since that's the only place it is used and improve logging
  #2815 - When not all units fit on screen brat editor scroll position jumps on re-render
- Support proper ELG sign-in and refreshing the access token
- Store ELG session in a new table instead of storing it in the project preferences. Reason is that project preferences are automatically included in the project export but we don't want the ELG session to be part of exported projects.
- Improve token refreshing
- Improve UI
- Fix dependencies
- Clear service search field when changing service
- Auto-format
- Organize imports
- Enable ELG recommender by default
@reckart reckart merged commit 48a439e into main Jan 17, 2022
@reckart reckart deleted the feature/2813-Recommender-calling-out-to-an-ELG-service branch January 17, 2022 19:23
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant