Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2833 - Enhance (external) editors API #2834

Merged
merged 3 commits into from
Jan 29, 2022

Conversation

reckart
Copy link
Member

@reckart reckart commented Jan 29, 2022

What's in the PR

  • Allow sending the editor ID to the view
  • Allow formats to specify CSS stylesheets that should be used when being rendered in styleable editors
  • Pass target element to external editor only as element and not as ID
  • Improve CSS and JavaScript injection in external editor factory

How to test manually

  • No specific test procedure

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Allow sending the editor ID to the view
- Allow formats to specify CSS stylesheets that should be used when being rendered in styleable editors
- Pass target element to external editor only as element and not as ID
- Improve CSS and JavaScript injection in external editor factory
@reckart reckart added this to the 23.0 milestone Jan 29, 2022
@reckart reckart self-assigned this Jan 29, 2022
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Jan 29, 2022
@reckart reckart merged commit 35be4c1 into main Jan 29, 2022
@reckart reckart deleted the refactoring/2833-Enhance-external-editors-API branch January 29, 2022 20:44
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant