Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#878 - Unhide annotation suggestions immediately if an overlapping annotation is deleted #2845

Conversation

reckart
Copy link
Member

@reckart reckart commented Feb 4, 2022

What's in the PR

  • Do not skip visibility calculation if there are no annotations
  • Ensure that suggestions in the current window are un-hidden as part of visibility calculation check - and then hidden again if necessary
  • Added tests

How to test manually

  • See issue description

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

…notation is deleted

- Do not skip visibility calculation if there are no annotations
- Ensure that suggestions in the current window are un-hidden as part of visibility calculation check - and then hidden again if necessary
- Added tests
@reckart reckart added 🐛Bug Something isn't working Module: Recommender labels Feb 4, 2022
@reckart reckart added this to the 23.0 milestone Feb 4, 2022
@reckart reckart self-assigned this Feb 4, 2022
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Feb 4, 2022
@reckart reckart merged commit 4c95723 into main Feb 5, 2022
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Feb 5, 2022
@reckart reckart deleted the bugfix/878-Unhide-annotation-suggestions-immediately-if-an-overlapping-annotation-is-deleted branch February 5, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Recommender
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant