Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2846 Trim down pdf editor code #2847

Merged
merged 7 commits into from
Feb 5, 2022

Conversation

reckart
Copy link
Member

@reckart reckart commented Feb 5, 2022

What's in the PR

  • Switch from webpack to esbuild
  • Remove tons of unused code

How to test manually

  • Try the PDF editor

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Remove unused HTML and JS code
- Remove more unused JS
- Do not compile debugger.js
- Do not load debugger.js on index.html
- Remove more unused JS
- Remove unused label editing code
- Adjust build process to not copy JS to target folder before building so it can be more easily used with VSCode
- Build pdfanno.core module using esbuild
- Drop webpack build entirely and switch to esbuild
- Move static code to another directory (pdfjs) and add that as another resource folder to the build
- Remove more unused stuff related to the old way of building things
- Removed tons of dependencies
@reckart reckart added this to the 23.0 milestone Feb 5, 2022
@reckart reckart self-assigned this Feb 5, 2022
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Feb 5, 2022
@reckart reckart merged commit ef5b196 into main Feb 5, 2022
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Feb 5, 2022
@reckart reckart deleted the refactoring/2846-Trim-down-PDF-editor-code branch February 5, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant