Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2891 - Predictions are not cleared after deleting the last annotation #2892

Merged
merged 1 commit into from
Mar 15, 2022
Merged

#2891 - Predictions are not cleared after deleting the last annotation #2892

merged 1 commit into from
Mar 15, 2022

Conversation

reckart
Copy link
Member

@reckart reckart commented Mar 14, 2022

What's in the PR

  • Lack of training annotations is no reason to skip prediction

How to test manually

  • Should be reproducible using a string recommender

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#2891 - Predictions are not cleared after deleting the last annotation
fa32de2 
- Lack of training annotations is no reason to skip prediction
@reckart reckart added 🐛Bug Something isn't working Module: Recommender labels Mar 14, 2022
@reckart reckart added this to the 23.0 milestone Mar 14, 2022
@reckart reckart self-assigned this Mar 14, 2022
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Mar 14, 2022
@reckart reckart merged commit 6608fa7 into main Mar 15, 2022
@reckart reckart deleted the bugfix/2891-Predictions-are-not-cleared-after-deleting-the-last-annotation branch March 15, 2022 05:47
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Recommender
Projects
Kanban
  
🍹 Done
Milestone
23.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@reckart