Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2908 - Allow loading only annotations - no text - via DIAM #2909

Merged
merged 6 commits into from Mar 25, 2022
Merged

#2908 - Allow loading only annotations - no text - via DIAM #2909

merged 6 commits into from Mar 25, 2022

Conversation

reckart
Copy link
Member

@reckart reckart commented Mar 24, 2022

What's in the PR

  • Allow not requesting text
  • Add WS endpoint to DIAM properties

How to test manually

  • No specific test procedure

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#2908 - Allow loading only annotations - no text - via DIAM
c056b80 
- Allow not requesting text
- Add WS endpoint to DIAM properties
@reckart reckart added this to the 24.0 milestone Mar 24, 2022
@reckart reckart self-assigned this Mar 24, 2022
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Mar 24, 2022
@reckart
#2908 - Allow loading only annotations - no text - via DIAM
9c6ef52 
- Fix test
@reckart
#2908 - Allow loading only annotations - no text - via DIAM
66d8b36 
- Options to loadAnnotations should be optional
- Adjust builtin editors to API change in loadAnnotations
@reckart
#2908 - Allow loading only annotations - no text - via DIAM
0a0d1c1 
- Backwards compatibility
@reckart
#2908 - Allow loading only annotations - no text - via DIAM
8251d10 
- Missing dependencies
@reckart
Merge branch 'main' into feature/2908-Allow-loading-only-annotations-…
f81bd9b 
…--no-text---via-DIAM

* main:
  #2393 - Remove outdated project fixings
  #2393 - Remove outdated project fixings
@reckart
Copy link
Member Author

reckart commented Mar 25, 2022

Jenkins, can you test this please?

@reckart reckart merged commit b316ca8 into main Mar 25, 2022
@reckart reckart deleted the feature/2908-Allow-loading-only-annotations---no-text---via-DIAM branch March 25, 2022 19:28
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: JavaScript Editor API
Projects
Kanban
  
🍹 Done
Milestone
24.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@reckart