Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2915 - Sentence layer should not be selectable as recommender target #2916

Conversation

reckart
Copy link
Member

@reckart reckart commented Mar 27, 2022

What's in the PR

  • Filter sentence layer from selection list
  • Code cleaning

How to test manually

  • Try creating a recommender and check if the sentence layer can be selected

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Filter sentence layer from selection list
- Code cleaning
@reckart reckart added 🐛Bug Something isn't working Module: Recommender labels Mar 27, 2022
@reckart reckart added this to the 23.0 milestone Mar 27, 2022
@reckart reckart self-assigned this Mar 27, 2022
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Mar 27, 2022
@reckart reckart merged commit 1a83e37 into release/22.x Mar 27, 2022
@reckart reckart deleted the bugfix/2915-Sentence-layer-should-not-be-selectable-as-recommender-target branch March 27, 2022 09:34
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Recommender
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant