Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2943 - Duplicate key error in active learning #2950

Merged
merged 3 commits into from
Apr 5, 2022
Merged

#2943 - Duplicate key error in active learning #2950

merged 3 commits into from
Apr 5, 2022

Conversation

reckart
Copy link
Member

@reckart reckart commented Apr 5, 2022

What's in the PR

  • Filter suggestions to reorder by the recommender which provided the currently active-learning-selected suggestion because scores may not be comparable across recommenders
  • Display score (detail) in dropdown in the combo box
  • Handle case that there may be multiple recommendations for the same label (which might actually not be necessary anymore due to the change above)

How to test manually

  • Configure two recommenders e.g. Token Sequence Classifier and String Matcher on a POS-annotated document
  • In active learning mode, find a location where both suggest the same label
  • There should not be an error

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#2943 - Duplicate key error in active learning
11ae5bc 
- Filter suggestions to reorder by the recommender which provided the currently active-learning-selected suggestion because scores may not be comparable across recommenders
- Display score (detail) in dropdown in the combo box
- Handle case that there may be multiple recommendations for the same label (which might actually not be necessary anymore due to the change above)
@reckart reckart added 🐛Bug Something isn't working Module: Recommender labels Apr 5, 2022
@reckart reckart added this to the 23.1 milestone Apr 5, 2022
@reckart reckart self-assigned this Apr 5, 2022
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Apr 5, 2022
@reckart
Merge branch 'release/23.x' into bugfix/2943-Duplicate-key-error-in-a…
9410058 
…ctive-learning

* release/23.x:
  #2949 - Error when trying to lock documents via bulk change
  #2948 - Error when dependency layer has been deleted from project
  #2948 - Error when dependency layer has been deleted from project
  No issue. Fix warning about checkbox without markup id.
  #2946 - PDF editor resources missing from release
  #2946 - PDF editor resources missing from release
@reckart
#2943 - Duplicate key error in active learning
f9856f2 
- Fix reference to renamed method
@reckart reckart merged commit d9ebecc into release/23.x Apr 5, 2022
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Apr 5, 2022
@reckart reckart deleted the bugfix/2943-Duplicate-key-error-in-active-learning branch April 5, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Recommender
Projects
Kanban
  
🍹 Done
Milestone
23.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@reckart