Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3113 - Option to wait for recommendations before showing document #3114

Merged
merged 4 commits into from Jun 11, 2022
Merged

#3113 - Option to wait for recommendations before showing document #3114

merged 4 commits into from Jun 11, 2022

Conversation

reckart
Copy link
Member

@reckart reckart commented Jun 11, 2022

What's in the PR

  • Added a per-project option to wait for non-trainable recommenders to provide suggestions before accessing a document (off by default)
  • Refactoring of the recommender tasks
  • Refactoring of the selection task to be more readable

How to test manually

  • Configure a non-trainable recommender, e.g. a non-trainable external recommender or an ELG recommender
  • Access the annotation page with the option disabled - access should be immediate, recommendations may appear only later
  • Log out - log back in
  • Enable the wait option and then access the annotation page - access should be blocked until recommendations have been retrieved (or until ELG runs into a timeout...)

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#3113 - Option to wait for recommendations before showing document
6d914e8 
- Added a per-project option to wait for non-trainable recommenders to provide suggestions before accessing a document (off by default)
- Refactoring of the recommender tasks
- Refactoring of the selection task to be more readable
@reckart reckart added this to the 24.0 milestone Jun 11, 2022
@reckart reckart self-assigned this Jun 11, 2022
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Jun 11, 2022
@reckart reckart merged commit 6a90b5f into main Jun 11, 2022
@reckart reckart deleted the feature/3113-Option-to-wait-for-recommendations-before-showing-document branch June 11, 2022 18:53
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Recommender
Projects
Kanban
  
🍹 Done
Milestone
24.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@reckart