Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3134 - Improved CAS Doctor checks #3138

Merged
merged 3 commits into from Jun 21, 2022
Merged

#3134 - Improved CAS Doctor checks #3138

merged 3 commits into from Jun 21, 2022

Conversation

reckart
Copy link
Member

@reckart reckart commented Jun 20, 2022

What's in the PR

  • Added new checks and repairs including documentation and tests: SwitchBeginAndEndOnNegativeSizedAnnotationsRepair, NegativeSizeAnnotationsCheck, AllAnnotationsStartAndEndWithinSentencesCheck, CoverAllTextInSentencesRepair, TokensAndSententencedDoNotOverlapCheck
  • Improved error reporting in the annotation editor code when a document cannot be rendered

How to test manually

  • Try the CAS doctor on a few funky XMI files

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#3134 - Improved CAS Doctor checks
8b1eb05 
- Added new checks and repairs including documentation and tests: SwitchBeginAndEndOnNegativeSizedAnnotationsRepair, NegativeSizeAnnotationsCheck, AllAnnotationsStartAndEndWithinSentencesCheck, CoverAllTextInSentencesRepair, TokensAndSententencedDoNotOverlapCheck
- Improved error reporting in the annotation editor code when a document cannot be rendered
@reckart reckart added this to the 24.0 milestone Jun 20, 2022
@reckart reckart self-assigned this Jun 20, 2022
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Jun 20, 2022
@reckart
#3134 - Improved CAS Doctor checks
599dc87 
- Fixed dependencies
@reckart
Merge branch 'main' into feature/3134-Improved-CAS-Doctor-checks
f7d3eb8 
* main:
  #3132 - Clean up brat editor
  #3136 - Support reading compressed CASes from 24.0
@reckart reckart merged commit 17e2482 into main Jun 21, 2022
@reckart reckart deleted the feature/3134-Improved-CAS-Doctor-checks branch June 21, 2022 06:49
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: CAS Doctor
Projects
Kanban
  
🍹 Done
Milestone
24.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@reckart