Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1088 - Create spans across page boundaries in PDF editor #3253

Conversation

reckart
Copy link
Member

@reckart reckart commented Jul 30, 2022

What's in the PR

How to test manually

  • Create an annotation in the brat view that goes across a page boundary, then look at it in the PDF view
  • Drag a selection across a page boundary to create a cross-page annotation

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Consider the page of each glyph when merging rectangles
- Consider the page of rectangles when rendering
- Fixes rendering of annotations that go across page boundaries
- Also fixes selection of text across page boundaries
@reckart reckart added this to the 24.0 milestone Jul 30, 2022
@reckart reckart self-assigned this Jul 30, 2022
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Jul 30, 2022
@reckart reckart changed the base branch from main to release/24.x July 30, 2022 21:41
@reckart reckart merged commit e1f4729 into release/24.x Jul 31, 2022
@reckart reckart deleted the feature/1088-Create-spans-across-page-boundaries-in-PDF-editor branch July 31, 2022 08:42
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

Create spans across page boundaries in PDF editor Render spans across page boundaries in PDF editor
1 participant