Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3242 - Tag not saved when moving to next tag #3316

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented Aug 28, 2022

What's in the PR

  • Delay DIAM calls if necessary to give feature editors a moment to commit
  • Remove commit delay (in backend) from feature editors to give them priority
  • When opening context menu via DIAM, give feature editors time to commit
  • Use DIAM to open context menu in brat
  • Fix feature editor committing value when selecting a new span in pdf editor
  • Mark more "custom action" code as deprecated
  • Suppress rendering while performing a selection and render afterwards if new data has been recieved (brat)

How to test manually

  • See issue description - try different editors

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Delay DIAM calls if necessary to give feature editors a moment to commit
- Remove commit delay (in backend) from feature editors to give them priority
- When opening context menu via DIAM, give feature editors time to commit
- Use DIAM to open context menu in brat
- Fix feature editor committing value when selecting a new span in pdf editor
- Mark more "custom action" code as deprecated
- Suppress rendering while performing a selection and render afterwards if new data has been recieved
@reckart reckart added 🐛Bug Something isn't working Module: Annotation labels Aug 28, 2022
@reckart reckart added this to the 24.2 milestone Aug 28, 2022
@reckart reckart self-assigned this Aug 28, 2022
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Aug 28, 2022
@reckart reckart merged commit 0753f2d into release/24.x Aug 28, 2022
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Aug 28, 2022
@reckart reckart deleted the bugfix/3242-Tag-not-saved-when-moving-to-next-tag branch August 28, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Annotation
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant