Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3877 - Show a bit of context in the annotation sidebar #3878

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented Mar 14, 2023

What's in the PR

  • Display part of the text after the covered text as muted text
  • No smart cut-off
  • Trailing text may cause annotation item to wrap and thereby take up more vertical space

How to test manually

  • Create a few annotations and check what they look like in the annotation sidebar

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

Demo
by-position

by-label

- Display part of the text after the covered text as muted text
- No smart cut-off
- Trailing text may cause annotation item to wrap and thereby take up more vertical space
@reckart reckart self-assigned this Mar 14, 2023
@reckart reckart modified the milestones: 27.1, 28.0 Mar 14, 2023
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Mar 14, 2023
- Avoid adding extra lines
- Fade out before it hits the label
- Put the fading wrapper around all labels if there are multiple labels
@reckart reckart marked this pull request as ready for review March 29, 2023 15:14
@reckart reckart merged commit d5947f5 into main Mar 29, 2023
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Mar 29, 2023
@reckart reckart deleted the feature/3877-Show-a-bit-of-context-in-the-annotation-sidebar branch March 29, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant