Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3918 - PubMed Central support #3919

Merged
merged 5 commits into from Apr 14, 2023
Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented Apr 4, 2023

What's in the PR

  • Basic PubMed Central support as external search
  • Very basic and experimental BioC support
  • Use Entrez to augment search results from PubAnnotation, e.g. so we can display titles
  • Improve visuals of the external search page

How to test manually

  • Create an external repository using the PubMed Central provider
  • Search and try importing documents

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Basic PubMed Central support as external search
- Very basic and experimental BioC support
- Use Entrez to augment search results from PubAnnotation, e.g. so we can display titles
- Improve visuals of the external search page
@reckart reckart added this to the 28.0 milestone Apr 4, 2023
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Apr 4, 2023
@reckart reckart self-assigned this Apr 4, 2023
* main:
  #3929 - Spaces in feature names not treated same as in layer names when indexing
  #3922 - Search results not showing
  #3926 - Projects may not delete if WebSocket-based event notification is enabled
  #3920 - Upgrade packages when building Docker container
  #3921 - Unable to merge slot filler when a feature in the project is disabled
  #3909 - Accept best button missing from recommendation sidebar
- Fix JavaDoc reference
@reckart reckart force-pushed the feature/3918-PubMed-Central-support branch from 7eeb6fe to 22dbf23 Compare April 6, 2023 05:06
* main:
  #3932 - Upgrade dependencies
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-27.4
@reckart reckart force-pushed the feature/3918-PubMed-Central-support branch 2 times, most recently from 4f610b7 to 3094cd3 Compare April 12, 2023 22:29
- DKPro Core 2.3.0 -> 2.3.1
- Sort results by relevance which is the same as on the PubMed website
- Avoid including results from the last 24 hours to reduce the risk that BioC documents are not available for them
- Better support for annotations in BioC documents
- More testing
@reckart reckart force-pushed the feature/3918-PubMed-Central-support branch from 3094cd3 to c0adfb7 Compare April 13, 2023 08:32
@reckart reckart marked this pull request as ready for review April 14, 2023 06:40
@reckart reckart merged commit 4cb72ae into main Apr 14, 2023
1 check passed
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Apr 14, 2023
@reckart reckart deleted the feature/3918-PubMed-Central-support branch April 14, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant