#3969 - Review and improve visibility calculation code #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch various variables to `var` - Move code hiding a suggestion based on a learning record status to a central place - Removed some redundant parameters from methods
- Pull a rejectSuggestion call out into the RecommendationServiceImpl - Consolidate code in the RecommendationEditorExtension
- Further clean up and consolidate code
- Further clean up and consolidate code
- Fix JavaDoc issues
reckart
force-pushed
the
refactoring/3969-Review-and-improve-visibility-calculation-code
branch
from
0301fb1
to
135da0d
Compare
- Further refactoring - in particular trying to properly centralize accept, correct and reject actions into the recommender service
…ty-calculation-code * main: No issue: Add rootPath method to XmlNodeUtils
- Merge LearningRecordService into the RecommendationService - Further centralize accepting/rejecting/skipping/etc. of suggestions in the recommender service
- Add a write-through cache for the learning records to the recommender state
…ty-calculation-code * main: #3975 - Upgrade dependencies (27.7) % Conflicts: % pom.xml
reckart
deleted the
refactoring/3969-Review-and-improve-visibility-calculation-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
varHow to test manually
Automatic testing
Documentation