Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1511 - External recommender fails when CAS contains control characters #4045

Merged
merged 1 commit into from
May 30, 2023
Merged

#1511 - External recommender fails when CAS contains control characters #4045

merged 1 commit into from
May 30, 2023

Conversation

reckart
Copy link
Member

@reckart reckart commented May 30, 2023

What's in the PR

  • Sanitize data before passing it to the XMI serializer - replacing problematic characters with spaces in text nodes and attributes
  • Added unit test

How to test manually

  • Set up a project with an external recommender
  • Import a document that contains control characters, e.g. \u0000 somewhere
  • See if sending the document to the external recommender fails or works (should work now)

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added 🐛Bug Something isn't working Module: Recommender labels May 30, 2023
@reckart reckart added this to the 28.2 milestone May 30, 2023
@reckart reckart self-assigned this May 30, 2023
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation May 30, 2023
@reckart
#1511 - External recommender fails when CAS contains control characters
745bd41 
- Sanitize data before passing it to the XMI serializer - replacing problematic characters with spaces in text nodes and attributes
- Added unit test
@reckart reckart force-pushed the bugfix/1511-External-recommender-fails-when-CAS-contains-control-characters branch from d900012 to 745bd41 Compare May 30, 2023 16:57
@reckart reckart merged commit 16289c6 into release/28.x May 30, 2023
1 check passed
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done May 30, 2023
@reckart reckart deleted the bugfix/1511-External-recommender-fails-when-CAS-contains-control-characters branch May 30, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Recommender
Projects
Kanban
  
🍹 Done
Milestone
28.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@reckart