Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1496 - Some spans are missing begin offset field #4046

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented May 30, 2023

What's in the PR

  • Disable omission of default values for legacy UIMA JSON format
  • Add option to switch to previous behavior of omitting default values
  • Updated documentation

How to test manually

  • Export basically any file as legacy JSON and check if the sofa string item has a begin: 0 property.

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Disable omission of default values for legacy UIMA JSON format
- Add option to switch to previous behavior of omitting default values
- Updated documentation
@reckart reckart added the 🐛Bug Something isn't working label May 30, 2023
@reckart reckart added this to the 28.2 milestone May 30, 2023
@reckart reckart self-assigned this May 30, 2023
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation May 30, 2023
…egin-offset-field

* release/28.x:
  #1511 - External recommender fails when CAS contains control characters
@reckart reckart force-pushed the bugfix/1496-Some-spans-are-missing-begin-offset-field branch from 90663f9 to b8755ec Compare May 30, 2023 18:15
@reckart reckart merged commit 61dfc54 into release/28.x May 30, 2023
1 check passed
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done May 30, 2023
@reckart reckart deleted the bugfix/1496-Some-spans-are-missing-begin-offset-field branch May 30, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant