Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4530 - Keyboard shortcuts for feature values may not work in certain editors #4531

Conversation

reckart
Copy link
Member

@reckart reckart commented Feb 20, 2024

What's in the PR

  • shortcut.js fails if the keyboard event target is the document node - try dispatching the event through the body instead

How to test manually

  • See issue description

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

… editors

- shortcut.js fails if the keyboard event target is the document node - try dispatching the event through the body instead
@reckart reckart added 🐛Bug Something isn't working Module: Annotation labels Feb 20, 2024
@reckart reckart added this to the 31.1 milestone Feb 20, 2024
@reckart reckart self-assigned this Feb 20, 2024
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Feb 20, 2024
@reckart reckart merged commit 8bce936 into release/31.x Feb 20, 2024
2 checks passed
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Feb 20, 2024
@reckart reckart deleted the bugfix/4530-Keyboard-shortcuts-for-feature-values-may-not-work-in-certain-editors branch February 20, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Annotation
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant