Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4590 - Agreement report shows only "no position" #4593

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented Mar 5, 2024

What's in the PR

  • Fix aggregation logic for "empty" and "all null" flags
  • When calculating the macro average agreement, skip results for which agreement calculation was not possible (NaN)
  • Display in the tooltip for how many documents agreement calculation was attempted and how many of those actually produced usable results

How to test manually

  • Try running agreement on your projects and check if the results appear to be sensible

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Fix aggregation logic for "empty" and "all null" flags
- When calculating the macro average agreement, skip results for which agreement calculation was not possible (NaN)
- Display in the tooltip for how many documents agreement calculation was attempted and how many of those actually produced usable results
@reckart reckart added this to the 31.2 milestone Mar 5, 2024
@reckart reckart self-assigned this Mar 5, 2024
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Mar 5, 2024
@reckart reckart merged commit 2e6ff05 into release/31.x Mar 5, 2024
2 checks passed
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Mar 5, 2024
@reckart reckart deleted the bugfix/4590-Agreement-report-shows-only-no-position branch March 5, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant