Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1319 - Cross-Layer Relations #4661

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented Mar 24, 2024

What's in the PR

  • Allow choosing "Any" as the attach layer when creating a new relation layer
  • Added feature switch

How to test manually

  • Try creating a new relation layer that connect to "any" span layer
  • But really, it's quite too early to test because cross-layer relations cannot be created yet in the annotation editor

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added this to the 32.0 milestone Mar 24, 2024
@reckart reckart self-assigned this Mar 24, 2024
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Mar 24, 2024
- Allow choosing "Any" as the attach layer when creating a new relation layer
@reckart reckart force-pushed the feature/1319-Cross-Layer-Relations branch from 7f5c4e8 to b5f7644 Compare March 24, 2024 18:27
- Rearranging and simplifying the AnnotationDetailEditorPanel code
- Generally cleaning up and modernizing
@reckart reckart force-pushed the feature/1319-Cross-Layer-Relations branch from d7795b5 to 609f8db Compare March 24, 2024 22:36
- More cleaning up
- Reduce usage of createOrUpdateFeature from the AnnotationDetailEditorPanel
@reckart reckart marked this pull request as ready for review March 25, 2024 07:07
@reckart reckart merged commit 7327ada into main Mar 25, 2024
3 checks passed
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Mar 25, 2024
@reckart reckart deleted the feature/1319-Cross-Layer-Relations branch March 25, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant