Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4796 - Annotation popover is not destroyed when switching between documents #4797

Conversation

reckart
Copy link
Member

@reckart reckart commented May 9, 2024

What's in the PR

  • Destroy the popover in brat, apache annotator, pdf and recogito editors
  • Fix an exception in the popover when a rendering/moving is triggered while the element the component is attached to is already gone

How to test manually

  • See issue description

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

…cuments

- Destroy the popover in brat, apache annotator, pdf and recogito editors
- Fix an exception in the popover when a rendering/moving is triggered while the element the component is attached to is already gone
@reckart reckart added this to the 32.2 milestone May 9, 2024
@reckart reckart self-assigned this May 9, 2024
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation May 9, 2024
@reckart reckart merged commit 198eb38 into release/32.x May 9, 2024
3 checks passed
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done May 9, 2024
@reckart reckart deleted the bugfix/4796-Annotation-popover-is-not-destroyed-when-switching-between-documents branch May 9, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant