Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#815 - Sub-properties not taken into account for getStatementGroupComparator() #817

Merged
merged 4 commits into from Jan 3, 2019
Merged

#815 - Sub-properties not taken into account for getStatementGroupComparator() #817

merged 4 commits into from Jan 3, 2019

Conversation

MdeBoer95
Copy link
Contributor

@MdeBoer95 MdeBoer95 commented Jan 3, 2019 •
edited by reckart

What's in the PR

  • subproperty labels are taken into account by the statementgroup comarator of Concept-/Instance-/Property-InfoPanel
  • check if the property is a subproperty
  • prefer baseProperties in the PropertyPanel

How to test manually

  • check if subproperty labels appear at the top of the statement group
    (base properties/domain/range can be above)

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@MdeBoer95
#815 - Sub-properties not taken into account for getStatementGroupCom…
c642346 
…parator()

- check if the property is a subproperty
- prefer baseProperties in the PropertyPanel
@MdeBoer95 MdeBoer95 added 🐛Bug Something isn't working Module: Knowledge Base labels Jan 3, 2019
@MdeBoer95 MdeBoer95 self-assigned this Jan 3, 2019
@ukp-svc-jenkins
Copy link

47% (+4.6%) vs master 43%

@ukp-svc-jenkins
Copy link

47% (+4.6%) vs master 43%

@reckart reckart changed the title #815 - Sub-properties not taken into account for getStatementGroupCom… #815 - Sub-properties not taken into account for getStatementGroupComparator() Jan 3, 2019
@ukp-svc-jenkins
Copy link

47% (+4.6%) vs master 43%

@reckart
#815 - Sub-properties not taken into account for getStatementGroupCom…
73610fb 
…parator()

- Introduced a local cache to reduce the number of SPARQL queries a bit
@ukp-svc-jenkins
Copy link

47% (+4.6%) vs master 43%

reckart
reckart approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@reckart reckart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a cache to reduce the performance impact of the additional lookups.

@reckart reckart added this to the 0.7.0 milestone Jan 3, 2019
@reckart reckart added this to In progress in Knowledge Base [M2] via automation Jan 3, 2019
@reckart reckart merged commit dc1f7f5 into master Jan 3, 2019
Knowledge Base [M2] automation moved this from In progress to Done Jan 3, 2019
@reckart reckart deleted the bugfix/815-sub_properties_not_taken_into_account_for_statement_group_comparator branch January 3, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reckart reckart reckart approved these changes

Assignees

@MdeBoer95 MdeBoer95

Labels
🐛Bug Something isn't working Module: Knowledge Base
Projects
No open projects
Knowledge Base [M2]
  
Done
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MdeBoer95 @ukp-svc-jenkins @reckart