New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noise FWHM in nidm namespace #328
Conversation
+1 |
Do the terms have the same definition in SPM and FSL? |
Yes, current definitions (for SPM) are generic and could also be used for FSL:
|
OK, thanks. +1 |
For the record, FSL and SPM use different methods to estimate the FWHM (FSL uses correlation of residuals at pairs of adjacent voxels; SPM uses variance of the difference of residuals at pairs of adjacent voxels), but they are both trying to estimate the same intrinsic thing. |
Ok, so in a sense they have different "definitions". This seems to be a case where we should decide an overall strategy for this issue. My view is that this is the kind of info that one would want to capture in the provenance, especially since we (i.e., you) actually know the difference. So in the case where we could write a generic definition to cover all cases, but the underlying method is different, could we use the generic definition language, but then have a second sentence saying what method is used? |
We discussed this on NIDASH call on May 11th (Minutes). |
fea9ef9
to
8bb0e24
Compare
8bb0e24
to
2fee3a8
Compare
(Rebased on master). I am going to merge this as agreed on NIDASH call on May 11th. |
This is a proposal to move the "noiseFWHM" terms (i.e.
spm:'noise FWHM in units'
,spm:'noise FWHM in voxels'
andspm:'noise FWHM in vertices'
) to the nidm namespace.We initially created those terms in the SPM namespace because those values were only reported for SPM results. But:
'noise FWHM in units'
and'noise FWHM in voxels'
for FSL (implemented in cmaumet/nidmresults-fsl@82c51f9).