Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noise FWHM in nidm namespace #328

Merged
merged 5 commits into from May 21, 2015

Conversation

cmaumet
Copy link
Member

@cmaumet cmaumet commented May 11, 2015

This is a proposal to move the "noiseFWHM" terms (i.e. spm:'noise FWHM in units', spm:'noise FWHM in voxels' and spm:'noise FWHM in vertices') to the nidm namespace.

We initially created those terms in the SPM namespace because those values were only reported for SPM results. But:

@nicholst
Copy link
Contributor

+1

@khelm
Copy link
Contributor

khelm commented May 11, 2015

Do the terms have the same definition in SPM and FSL?

@cmaumet
Copy link
Member Author

cmaumet commented May 11, 2015

Yes, current definitions (for SPM) are generic and could also be used for FSL:

@khelm
Copy link
Contributor

khelm commented May 11, 2015

OK, thanks. +1

@nicholst
Copy link
Contributor

For the record, FSL and SPM use different methods to estimate the FWHM (FSL uses correlation of residuals at pairs of adjacent voxels; SPM uses variance of the difference of residuals at pairs of adjacent voxels), but they are both trying to estimate the same intrinsic thing.

@khelm
Copy link
Contributor

khelm commented May 11, 2015

Ok, so in a sense they have different "definitions". This seems to be a case where we should decide an overall strategy for this issue. My view is that this is the kind of info that one would want to capture in the provenance, especially since we (i.e., you) actually know the difference. So in the case where we could write a generic definition to cover all cases, but the underlying method is different, could we use the generic definition language, but then have a second sentence saying what method is used?

@cmaumet
Copy link
Member Author

cmaumet commented May 11, 2015

We discussed this on NIDASH call on May 11th (Minutes).

@cmaumet cmaumet force-pushed the fwhm_in_nidm_namespace branch 2 times, most recently from fea9ef9 to 8bb0e24 Compare May 16, 2015 11:04
@cmaumet
Copy link
Member Author

cmaumet commented May 21, 2015

(Rebased on master). I am going to merge this as agreed on NIDASH call on May 11th.

cmaumet pushed a commit that referenced this pull request May 21, 2015
@cmaumet cmaumet merged commit d357deb into incf-nidash:master May 21, 2015
@cmaumet cmaumet deleted the fwhm_in_nidm_namespace branch May 21, 2015 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants