Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search volume in units (and in vertices) in nidm namespace #300

Merged
merged 2 commits into from Apr 14, 2015
Merged

Search volume in units (and in vertices) in nidm namespace #300

merged 2 commits into from Apr 14, 2015

Conversation

cmaumet
Copy link
Member

@cmaumet cmaumet commented Apr 14, 2015

Similarly to what was done in #269 for "searchVolumeInVoxels", could we:

  • replace spm:searchVolumeInUnits by a generic term in the nidm namespace: nidm:searchVolumeInUnits
  • replace spm:searchVolumeInVertices by a generic term in the nidm namespace: nidm:searchVolumeInVertices;

?

@khelm
Copy link
Contributor

khelm commented Apr 13, 2015

+1 for consistency

@nicholst
Copy link
Contributor

+1, consistent with #301

@cmaumet
Copy link
Member Author

cmaumet commented Apr 14, 2015

Thank you! Now implemented. Let's wait for the tests to pass and then merge.

cmaumet pushed a commit that referenced this pull request Apr 14, 2015
Merge pull request #300 from cmaumet/namespace_search_volume
6b63819 
Search volume in units (and in vertices) in nidm namespace
@cmaumet cmaumet merged commit 6b63819 into incf-nidash:master Apr 14, 2015
@cmaumet cmaumet deleted the namespace_search_volume branch April 14, 2015 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cmaumet @khelm @nicholst