Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If np is missing from a section, raise a proper error message #45

Open
jakobj opened this issue Oct 18, 2017 · 3 comments
Open

If np is missing from a section, raise a proper error message #45

jakobj opened this issue Oct 18, 2017 · 3 comments

Comments

@jakobj
Copy link
Contributor

jakobj commented Oct 18, 2017

If in the config file, one section is missing the np enttry, in ApplicationMapper::mapApplications () it is assigned a random(?) value. The resulting error reads something like the following:

Error in MUSIC library: configuration file specifies 32579 MPI processes but MUSIC was given 3

Instead, MUSIC should raise a proper error message complaining that np is missing.
It seems like there should in general be a function right after (cfile_->load (*configFile)) in ApplicationMapper::map that checks the validity of the config file. That way one could also check for all other errors arising from wrong specifications in the config file. Is there something like that already and I'm missing it?

@jakobj
Copy link
Contributor Author

jakobj commented Oct 19, 2017

I would like to revise my opinion. I think no error should be thrown, instead MUSIC should assume that if np is not provided, this application only uses one process. Other opinions?

@mdjurfeldt
Copy link
Contributor

mdjurfeldt commented Oct 19, 2017 via email

@jakobj
Copy link
Contributor Author

jakobj commented Oct 24, 2017

probably this could be extended to also set args="" as a default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants