Fix panic in waitForConsole #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve this error: ``` panic: interface conversion: runtime.Object is *v1.Status, not *unstructured.Unstructured ``` There was an assumption of the object type that didn't hold true. If a watch `ERROR` event type is received, then it should be cast to a `v1.Status` instead. To avoid this, skip the event if it's of this type. This is likely fine for this case, as per the comment. Also add some extra error handling. https://github.com/kubernetes/apimachinery/blob/fd8daa85285e31da9771dbe372a66dfa20e78489/pkg/watch/watch.go#L43-L70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve this error:
There was an assumption of the object type that didn't hold true. If a watch
ERRORevent type is received, then it should be cast to av1.Statusinstead.To avoid this, skip the event if it's of this type. This is likely fine for this case, as per the comment.
Also add some extra error handling.
https://github.com/kubernetes/apimachinery/blob/fd8daa85285e31da9771dbe372a66dfa20e78489/pkg/watch/watch.go#L43-L70