Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors CMakeLists.txt and makes it more robust #98

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

imlk0
Copy link
Collaborator

@imlk0 imlk0 commented Mar 26, 2024

The current CMakeLists.txt is problematic in that:

  1. external dependencies (openssl, curl) are not checked with find_package().
  2. no support for cmake's CMAKE_INSTALL_PREFIX, which may make it difficult to be integrated
  3. some typos incorrectly write librats as rats-tls.

So, this commit refactors CMakeLists.txt and makes it more robust.

Details:

  • LibCBOR.cmake: fix build
  • CMakeLists.txt: add find openssl
  • check openssl include
  • check CURL_INCLUDE_DIRS
  • CMakeLists.txt: add missing find_package curl
  • CMakeLists.txt: using CURL::libcurl instead of CURL_*
  • CMakeLists.txt: move find_package openssl to subdirectory
  • CMakeLists.txt: using CMAKE_INSTALL_PREFIX instead of RATS_INSTALL_PATH
  • remove find_package(OpenSSL) for wasm mode

- LibCBOR.cmake: fix build
- CMakeLists.txt: add find openssl
- check openssl include
- check CURL_INCLUDE_DIRS
- CMakeLists.txt: add missing find_package curl
- CMakeLists.txt: using CURL::libcurl instead of CURL_*
- CMakeLists.txt: move find_package openssl to subdirectory
- CMakeLists.txt: using CMAKE_INSTALL_PREFIX instead of RATS_INSTALL_PATH
- remove find_package(OpenSSL) for wasm mode

Signed-off-by: Kun Lai <me@imlk.top>
@imlk0 imlk0 merged commit a9cbdd2 into inclavare-containers:master Mar 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant