Unify the format of evidence_buffer #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial implementation of evidence_buffer has two forms. The first one is to put <pubkey-hash> into the userdata field of the evidence. The second is to put <pubkey-hash> into the claims_buffer. This commit removes support for the first form. Signed-off-by: Kun Lai <me@imlk.top>
This commit removes the log prints related to custom_claims from dice.c, since the same log prints exist in un_negotiate.c. This commit also omits the value fof claims in log print, to avoid log being contaminated by the printed binary content. Signed-off-by: Kun Lai <me@imlk.top>
6 tasks
haosanzi
approved these changes
Jan 31, 2023
Closed
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation of
evidence_bufferhas two forms. The first one is to put<pubkey-hash>into the userdata field of the evidence. The second is to put<pubkey-hash>into the claims_buffer.This commit removes support for the first form, since it has been deleted in the Interoperable RA-TLS proposal.
Signed-off-by: Kun Lai me@imlk.top