Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

googlePlaceId no longer exists in version 3 #282

Closed
andreialecu opened this issue Apr 4, 2024 · 3 comments · Fixed by #286
Closed

googlePlaceId no longer exists in version 3 #282

andreialecu opened this issue Apr 4, 2024 · 3 comments · Fixed by #286
Labels
released

Comments

@andreialecu
Copy link

Updated an app from v2 to v3 and it appears that the property googlePlaceId which was part of the Options interface as it was passed to <Popup options={...} no longer exists.

Seems like an oversight?
@andreialecu andreialecu mentioned this issue Apr 4, 2024
Merged
@tschoffelen
Copy link
Member

That might be an error in the Typescript definition, because I think it should still be accepted. Happy to accept a PR for this!

@meteorlxy meteorlxy mentioned this issue Apr 11, 2024
Merged
@meteorlxy
Copy link
Contributor

This issue would also be fixed by #286

meteorlxy added a commit to meteorlxy/react-native-map-link that referenced this issue Apr 11, 2024
@meteorlxy
fix: fix PopupProps and improve types (close includable#282, includab…
32bd01f 
…le#285)
meteorlxy added a commit to meteorlxy/react-native-map-link that referenced this issue Apr 11, 2024
@meteorlxy
fix: fix PopupProps and improve types (close includable#282, includab…
fafb0b9 
…le#285)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix PopupProps and improve types (close #282, #285) meteorlxy/react-native-map-link
3 participants
@tschoffelen @andreialecu @meteorlxy