New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing Each with range loops #310
Comments
I support this. We usually change them when we make related changes, but it's going so slow that I would prefer to make a one-time conversion to simplify the code. @vsapsai, are you OK with that? |
I don't see value in doing this. But if people think it is useful, sure, go ahead. |
Code which uses standard language features are more comprehensive, especially for outsiders. |
See PR #330 |
@EugeneZelenko, @kimgr, I want to apologize for my behavior. You provided valuable feedback and my snarky comment was inappropriate. I've been on the other side and now better understand negative impact of using custom solutions instead of standard language features. Thanks for sharing your experience and teaching me something new. |
@vsapsai: it didn't come out as snarky at all, no offense taken! |
Oh, thanks guys for your support. |
Looks like Each is relic of time when code was built in C++98/03. This is definitely obsolete when LLVM/Clang switched to C++11.
The text was updated successfully, but these errors were encountered: