Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Each with range loops #310

Closed
EugeneZelenko opened this issue May 20, 2016 · 8 comments
Closed

Replacing Each with range loops #310

EugeneZelenko opened this issue May 20, 2016 · 8 comments
Milestone

Comments

@EugeneZelenko
Copy link
Contributor

Looks like Each is relic of time when code was built in C++98/03. This is definitely obsolete when LLVM/Clang switched to C++11.

@kimgr
Copy link
Contributor

kimgr commented May 22, 2016

I support this. We usually change them when we make related changes, but it's going so slow that I would prefer to make a one-time conversion to simplify the code. @vsapsai, are you OK with that?

@vsapsai
Copy link
Contributor

vsapsai commented May 23, 2016

I don't see value in doing this. But if people think it is useful, sure, go ahead.

@EugeneZelenko
Copy link
Contributor Author

Code which uses standard language features are more comprehensive, especially for outsiders.

@kimgr
Copy link
Contributor

kimgr commented Jul 3, 2016

See PR #330

@kimgr kimgr closed this as completed in 5b61a55 Jul 11, 2016
@vsapsai
Copy link
Contributor

vsapsai commented Sep 19, 2016

@EugeneZelenko, @kimgr, I want to apologize for my behavior. You provided valuable feedback and my snarky comment was inappropriate. I've been on the other side and now better understand negative impact of using custom solutions instead of standard language features. Thanks for sharing your experience and teaching me something new.

@kimgr
Copy link
Contributor

kimgr commented Sep 19, 2016

@vsapsai: it didn't come out as snarky at all, no offense taken!

@EugeneZelenko
Copy link
Contributor Author

@vsapsai: I didn't see any offense in your comment. Sure, time is limited, so there are may be more important problems then code cleanups.

@kimgr: Thank you for code refactoring!

@vsapsai
Copy link
Contributor

vsapsai commented Sep 20, 2016

Oh, thanks guys for your support.

@kimgr kimgr modified the milestone: iwyu 0.7 Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants