This repository has been archived by the owner on Apr 30, 2021. It is now read-only.
5849: Fix for Unable to create table language_text and themes due to SQL version #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cindyli
reviewed
Mar 8, 2018
install/db/achecker_schema.sql
Outdated
| @@ -308,7 +308,7 @@ CREATE TABLE `themes` ( | |||
| `title` varchar(80) NOT NULL DEFAULT '', | |||
| `version` varchar(10) NOT NULL DEFAULT '', | |||
| `dir_name` varchar(20) NOT NULL DEFAULT '', | |||
| `last_updated` date NOT NULL DEFAULT '0000-00-00', | |||
| `last_updated` date NULL DEFAULT NULL, | |||
There was a problem hiding this comment.
It doesn't make sense to have the first "NULL".
|
@pranjaljn97, this pull request is far from completion. When addressing a problem in the system, we cannot address a small portion of it but leave the rest behind, which introduces the confusion and traps as well as affecting the code quality. |
|
I got your point. I was just trying to address the problem that I faced in the installation on the Local machine. |
|
If you don't have a clear picture of what needs to be done, please close this PR. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue No: 5849
Plese refer to bug report, http://www.atutor.ca/atutor/mantis/view.php?id=5849