GH-53: Add localization support (Resolves #53, #77, #80) #85
Conversation
|
@jobara - can we add a In particular I'd be looking for:
|
src/documents/pages/fr/index.md
Outdated
| Reprendre le Guide à différentes étapes de votre projet peut être une bonne façon de l'intégrer à votre travail. | ||
|
|
||
| </figcaption> | ||
| <span class="small-12 medium-6 large-4 column"> {% include "svg/schematic.svg" %} </span> |
There was a problem hiding this comment.
The aria label for this SVG uses the <title> and <description> elements from the SVG which needs to be translated.
I think the aria-label should be generated another way.
| *Illustration 2 :* Un participant présente le concept de son groupe qui avait pour tâche de créer une version | ||
| informatique du circuit de billes. |
There was a problem hiding this comment.
When rendered, a <br/> is injected between the lines causing a break. this happens with all captions.
This was never a problem because we never linted these md files before. :)
There was a problem hiding this comment.
This is caused by fluid-project/eleventy-plugin-fluid#76. I'll update the plugin once it has been addressed.
Co-authored-by: jhung <jhung@ocadu.ca>
jobara
changed the title
CONTRIBUTING.md
Outdated
| 1. Update the `Language` | ||
| 2. Update the localized text |
There was a problem hiding this comment.
@jobara can you give a little more detail here?
Co-authored-by: jhung <jhung@ocadu.ca>
|
@jhung ready for more review. |
Co-authored-by: jhung <jhung@ocadu.ca>
|
@jhung I merged your latest suggestions. |
|
merged at 9dbc40e |
Resolves #53
Resolves #77
Resolves #80