New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update projects permalink to be file name of projects (resolves #497) #511
Conversation
✅ Deploy Preview for idrc ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks for the fix, @chosww. Using file slugs does resolve 404 error when changing a project title. There's another feature request in the ticket - This feature requires to add an extra field on the authoring interface so that users can define the permalink. If users don't define it, the file slugs will be used. An example of this implementation can be found on the "Pages" authoring interface. See https://github.com/inclusive-design/idrc/blob/dev/src/admin/config.yml#L190. Moreover, it will be more user friendly to add a |
Oh, so we keep the field I talked about. But how would we ensure that the field value is unique? Projects with the same URL field value would be a problem. |
@jhung Could you check label and hint texts for projects permalink field please? Also, message to communicate required body field when permalink field is entered. Thanks! |
Co-authored-by: jhung <jhung@ocadu.ca>
npm run test
without errorsnpm run build
without errorsDescription
The issue described in #497 suggests using a new slug for projects to be used as url, but @cindyli said that adding the slug doesn't prevent 404 error. File name is unique to project, and even when I try to create a project with same title, duplicated file name is handled by 11ty by adding numbers after the file name, so the system guarantees file name to be unique.
Related issues
Resolves #497