New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve contrast ratio of some links when the design is ready #331
Comments
hi i am facing this problem when i add this COMMAND "NPM RUN START" plz anyone tell me how i run this project in my local plz help, |
@Raunaksingh100, did you hit the problem at running
|
For npm start we have to change the start command in package.json Is this correct or wrong ??? Or simpley add this commands in poweshell |
You don't need to change |
thanks its works @cindyli thanks a lot |
After implementing the design changes suggested in #322 to improve the visual appearance of the We Count website all of the contrast ratio issues mentioned still persist and now additionally includes the Tag Filter tags on Views page. To reproduce this:
|
@uttaraghodke, @lliskovoi: following @TeddTech's comment about the persistence of the contrast ratio problem, we discussed this in an email thread before and @jobara's research result gave a good summary: In WCAG 2.1, it defines the minimum contrast ratio to be 4.5:1 except for the case of Large Text (contrast ratio 3:1), incidental and logotypes. What is Large Text? Large scale text is defined as 18 point or 14 point bold. What is a point (pt) on a digital device? Well that’s confusing. (See: wcag issue #181). That discussion lead to an update to Understanding WCAG 2.1 document; which uses the CSS calculation and is based off a 16px base font if I’m not mistaken. 1pt = 1.333px, 14pt ≈ 18.5px and 18pt ≈ 24px. The cause of the problem still persists after the design change that increases the article font size from 16px to 18px for the desktop layout because the size of the large text in WCAG 2.1 spec is 24px. Moreover, the changed font size for the mobile layout is even smaller. I wonder if it would be more reasonable to increase contrast ratios by picking dark font colors or lighter background colors. |
At today's meeting, the link colors are decided to change to:
|
Describe the bug
Running lighthouse report on "Inclusion Challenges" page and News and Views post pages will report low contrast ratio on:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
These links should have higher contrast ratio.
The text was updated successfully, but these errors were encountered: