Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter checkmarks don't display properly when UIO line height changes #408

Closed
cindyli opened this issue Sep 25, 2020 · 0 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@cindyli
Copy link
Contributor

cindyli commented Sep 25, 2020

Describe the bug

Filter checkmarks don't display properly when UIO line height changes.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the Views page, open the filter section, click a checkbox, a checkmark shows;
  2. Open UIO, gradually increase the line height;
  3. Check the position of the checkmark. It stays at the same position but the checkbox gradually moves down which causes the checkmark no longer displays in the checkbox.

Expected behavior

The checkmark should always stay inside of the checkbox it belongs to.

Screenshots

Screen Shot 2020-09-25 at 10 14 37 AM

Additional context

Checkmarks are currently drawn using box-shadow and transform and displays using an absolute position. When the line height increases and contents adjust position accordingly, checkmarks stays in their absolution position and don't move along.

The solution is to replace the drawing method with content: '\2713';. \2713 is a css encoding for the checkmark symbol. Using content attribute will make checkmarks a part of the content, which will move along with other contents when the line height changes.

@cindyli cindyli added the bug Something isn't working label Sep 25, 2020
@cindyli cindyli added this to the 2.4.0 milestone Sep 25, 2020
@cindyli cindyli self-assigned this Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant