Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Android Java version to 1.8 (from 17) #87

Merged
merged 1 commit into from Feb 21, 2024

Conversation

KeeganDC
Copy link
Contributor

@KeeganDC KeeganDC commented Oct 31, 2023

Not sure if version 17 was needed for anything specifically but seems to run fine on lower Java version

Resolves issue #86

@DexterZP
Copy link

DexterZP commented Jan 3, 2024

@incrediblezayed

@callmephil
Copy link

My app does not directly depend on file_saver and it's preventing me from releasing it to production since. It would be great if this PR gets merged.

@coolswood
Copy link

@incrediblezayed

@incrediblezayed
Copy link
Owner

My sincerest apologies for such delayed response, I would love to fix the issues that everyone is facing but my hands are very tied, is it possible for you guys to probably wait till next weekend? @coolswood @callmephil @DexterZP

@coolswood
Copy link

Thank you so much for your reply! Of course we can wait, we just want to understand if it will be fixed).

@incrediblezayed
Copy link
Owner

Thank you so much for your reply! Of course we can wait, we just want to understand if it will be fixed).

Thank You so much for understanding & staying on my package, I will get this fixed soon somehow, either will merge the PR or go ahead & find something else, the java version was actually upgraded to fix an issue for certain user who requested the change, I'll see what I can do to work for both sides of the application

@Seferi
Copy link

Seferi commented Feb 21, 2024

It's been over a month since the last comment. Is there any update on this ? My CI builds are failing as well.

@incrediblezayed
Copy link
Owner

Hey, My Bad, I missed this once, I'll merge & push tonight

@incrediblezayed incrediblezayed merged commit 8af976b into incrediblezayed:main Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants