Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versioning strategy of dependabot #59

Merged
merged 1 commit into from Sep 6, 2023
Merged

Conversation

ohakutsu
Copy link
Member

@ohakutsu ohakutsu commented Sep 6, 2023

What

dependabotのPull Requestでpackage.jsonも更新されるようにした。

How

dependabot.ymlのnpmのversioning-strategyincreaseに変更した。

Why

Qiita CLIはツールとして使ってもらうものであるため、
依存パッケージのバージョンがユーザーそれぞれで異なることによって意図しない挙動が起こるのを避けたいため。

Refs

@ohakutsu ohakutsu self-assigned this Sep 6, 2023
@ohakutsu ohakutsu requested review from a team and tomoasleep and removed request for a team September 6, 2023 03:33
Copy link
Member

@tomoasleep tomoasleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qiita-cli はライブラリというよりは CLI ツールとしての使われ方が主なので、 widen でなく increase で違和感はないと思った。 Why 書いておいてくれると嬉しいです 🙏

@ohakutsu ohakutsu merged commit f40a39e into main Sep 6, 2023
5 checks passed
@ohakutsu ohakutsu deleted the fix-dependabot-yml branch September 6, 2023 07:00
@ohakutsu ohakutsu mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants