Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CI/CD platform from Travis CI to GitHub Actions #18

Merged
merged 4 commits into from
May 9, 2023
Merged

Migrate CI/CD platform from Travis CI to GitHub Actions #18

merged 4 commits into from
May 9, 2023

Conversation

takano32
Copy link
Contributor

closes #16

@takano32
Copy link
Contributor Author

@mziyut Would you review this PR?

mziyut
mziyut reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@mziyut mziyut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Would you please add the following to CHANGELOG.md?
(I'm not allowed to comment on files without a diff, so here it is.)

+ ## Unreleased
+
+ - Migrate CI/CD platform from Travis CI to GitHub Actions
+ 
 ## v1.3.5
 
 - Add project reaction methods

.github/workflows/rspec.yml Outdated Show resolved Hide resolved
.github/workflows/rspec.yml Outdated Show resolved Hide resolved
@takano32
Copy link
Contributor Author

sorry. i’ll fix in today.

takano32 and others added 3 commits April 29, 2023 08:38
@takano32 @mziyut
fix indent
354a238 
Update .github/workflows/rspec.yml

Co-authored-by: Yuta Mizui <me@mziyut.com>
@takano32 @mziyut
fix line breaks format
d952df6 
Update .github/workflows/rspec.yml

Co-authored-by: Yuta Mizui <me@mziyut.com>
@takano32
Update CHANGELOG.md
94f3d54
@takano32
Copy link
Contributor Author

takano32 commented Apr 28, 2023 •
edited
Loading

Thanks for your many suggestion with diffs!

And many diffs make me feel easy I can fix(accept diffs) almost all of them from iPhone while todays breakfast. 🍞

Have a nice day, you too. :)

mziyut
mziyut approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@mziyut mziyut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mziyut mziyut merged commit ea78c89 into increments:master May 9, 2023
@takano32 takano32 deleted the GitHub-Actions branch May 9, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mziyut mziyut mziyut approved these changes

Assignees

@takano32 takano32

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate CI/CD platform from Travis CI to GitHub Actions
2 participants
@takano32 @mziyut