-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
It doesn't use fullscreen API
Proper value strongly depends on where this package runs on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuku-t
The user is supposed to read _core.scss only (it is described in the README)
The scss variable is a setting to enable external injection, but is it necessary to change the variable name on it?
README describes as follows: Ok, let's suppose you are right (in other words README is wrong), then where the following qiita-slide-mode/src/styles/_core.scss Line 86 in a34825d
|
@yuku-t Sorry. It was supposed to be the default value. How about setting _vars as the default value and specifying in the README that if you want to expand it, ask that you overwrite it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is considered that it is good to change the name of course if it is set as the default value, I think that it is good in the direction of the variable name change.
This is the reason why I set
I think there is no difference between your opinion and this PR. Suppose I want to override $qiita-slide-mode-fullscree-z-index: 10;
@import "~@increments/qiita-slide-mode/src/styles/vars";
@import "~@increments/qiita-slide-mode/src/styles/core"; |
$qiita-slide-mode-
prefix to Sass variables. Global variables always face to collision problem. Seriously.!default
..fullscreen
. Proper z-index value strongly depends on where this package runs on.