This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
Remove "module" from package.json #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 18, 2018 17:42
since our src/*.js is written in ES2015
|
@yuku-t Could you explain these changes in more detail? For example, why is the output format |
It is because there is no need to support AMD. We are using rollup-plugin-commonjs, not require.js 😄 . |
|
The UMD build exists for the CDN bundle. If qiita-slide-mode is not going to be distributed over a CDN, then it's fine. In fact, we don't even need to bundle anything since we can assume users will bundle their application with this package by themselves using their own build configuration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript imports the "module" file. Since TypeScript doesn't transform imported files, our assets includes ES2015 syntax.